microsoft / microsoft/vscode-languageserver-node
WorkDoneProgressCancelNotification is not using the given cancellation strategy
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 404
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 14
Description
according to this - https://github.com/microsoft/vscode-languageserver-node/blob/main/server/src/common/progress.ts#L160 - workDoneProgressCancelNotification is using regular message for the cancellation notification.
this should use the same cancellation strategy provided like the regular cancellation messages - https://github.com/microsoft/vscode-languageserver-node/blob/main/jsonrpc/src/common/connection.ts#L1402, otherwise, anyone who uses custom cancellation strategy won't be able to use workdoneProgress's cancellation feature including ones who use sharedArrayCancellation for browser.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in server/src/common/progress.ts around WorkDoneProgressCancelNotification, then compare its cancellation handling with jsonrpc/src/common/connection.ts around the regular cancellation messages. Confirm the work-done progress cancellation path uses the supplied cancellation strategy, including custom strategies such as sharedArrayCancellation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100