microsoft / microsoft/vscode-json-languageservice

Recognize more colors

Open
#90 3 comments 0 reactions 1 assignee View on GitHub

@aeschli is already working on this.

Since Oct 25, 2021.

feature-request
Dominant language
TypeScript
Stars
326
Forks
145
Avg merge
22h 10m
Merged PRs (30d)
9

Description

Currently this server recognizes hex-encoded colors in the form of #rrggbbaa. Sublime text color schemes allow more variations. See https://www.sublimetext.com/docs/color_schemes.html#colors:ver-dev. These color schemes are written in a jsonc syntax. Ideally this server should parse those variations and present them via textDocument/documentColor.

It seems that vscode-css-language-server can already parse these kinds of variables. So that gives me an idea to port that code to vscode-json-languageservice, or perhaps they should share a common base.

Related: https://github.com/sublimelsp/LSP-json/issues/59

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.