microsoft / microsoft/vscode-json-languageservice

2019-09: meta-schema fetched on every resolution with $schema

Open
#331 0 comments 1 reaction 2 assignees View on GitHub

@aeschli is already working on this.

Since Jul 6, 2026.

  • #335 by @copilot-swe-agent — closed without merging
Dominant language
TypeScript
Stars
326
Forks
145
Avg merge
22h 10m
Merged PRs (30d)
9

Description

Found while reviewing #308 (JSON Schema 2019-09 support).

Problem

resolveMetaschemaVocabularies in src/services/jsonSchemaService.ts calls getUnresolvedSchema() on the $schema meta-schema for any schema that declares $schema. Bundled drafts are cached, but a custom $schema URI now triggers a network fetch that did not happen before this change.

Failures are handled gracefully (ignored) and results are cached, but this is new I/O per custom metaschema.

Suggested direction

Consider skipping the fetch when the draft can be determined without vocabularies, or documenting/limiting the extra request.

Severity

Low/Medium — new network I/O for custom metaschema URIs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.