microsoft / microsoft/vscode-js-debug

RFC: some errors should have `showUser` set to true

Open
#2,283 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2k
Forks
373
Avg merge
1d 9m
Merged PRs (30d)
6

Description

Hello!

I noticed that some errors have showUser set to false. In spite of that, VSCode shows these errors anyway (although maybe it shouldn't?). That's actually nice, since the errors are often helpful. However, since it introduces this inconsistency, the errors should instead have showUser set to true.

One example are the REPL errors, as can be seen here:

https://github.com/microsoft/vscode-js-debug/blob/74702375c67744e2f123d89ef950d7b6859c6f16/src/dap/errors.ts#L156

Thoughts?

Sample screenshot Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/dap/errors.ts, especially the REPL errors around line 156, and compare its showUser values with VS Code's debugService behavior linked in the issue. Determine which errors are intended to be user-visible and document the agreed scope; the work is done when the relevant error flags consistently reflect that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.