microsoft / microsoft/vscode-java-dependency
Could not auto close unsaved editor when delete
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 199
- Forks
- 105
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 27
Description
The newly added "delete" feature #343 works well when we try to delete unchanged files. However, if we try to delete file with unsaved changes, the editor will not be closed and will looks like below:
This is not consistent with native file explorer's behavior and may also cause user lose their changes before deletion. However, this part is hard to fix due to API limitation, since many needed functions are encapsulated within the implementation of VS Code built-in commands. If microsoft/vscode#107566 could be solved, we can fix this problem easily.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the delete feature from issue #343 and reproduce deletion of a file with unsaved changes in the VS Code extension. Read microsoft/vscode#107566 to understand the API limitation; done means the editor closes consistently with native file-explorer behavior without risking unsaved changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100