microsoft / microsoft/vscode-java-debug
Adopt argsCanBeInterpretedByShell
@testforstephen is already working on this.
Since Sep 19, 2022.
- Dominant language
- TypeScript
- Stars
- 591
- Forks
- 429
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 19
Description
When a debug adapter uses RunInTerminalRequest, vscode is now escaping characters for the shell by default, but we added a flag to RunInTerminalRequest to allow debug adapters to disable this escaping, which some users want. A user pointe this out for java in https://github.com/microsoft/vscode/issues/160999. This is adopted in js-debug and python, and I'd love to see it adopted for java. In js-debug and python, the args property can be a string or an array of strings. If it's just a string, the args are not escaped. I can talk more about what it will take to adopt this if needed.
See
https://code.visualstudio.com/updates/v1_70#_argscanbeinterpretedbyshell-for-runinterminalrequest
and
https://github.com/microsoft/debug-adapter-protocol/issues/146
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.