microsoft / microsoft/vscode-html-languageservice

Add new angular templating option from js-beautify v1.15.1

Open
#177 18 comments 50 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
284
Forks
138
Avg merge
19h 11m
Merged PRs (30d)
5

Description

js-beautify v1.15.1 added a new setting to support indenting of Angular at-string syntax (https://github.com/beautifier/js-beautify/pull/2247).

Previous additions were on-by-default. This new feature causes problems for non-angular users, so it is off by default.

It looks like the settings will need to be updated to allow supplying a list of templating formatters and add angular as an option:

https://github.com/microsoft/vscode-html-languageservice/blob/81cf18fc8aca3ac4ea1e5a99864731a3757260be/src/htmlLanguageTypes.ts#L31-L48

https://github.com/microsoft/vscode-html-languageservice/blob/81cf18fc8aca3ac4ea1e5a99864731a3757260be/src/beautify/beautify-html.d.ts#L119

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the settings definitions in src/htmlLanguageTypes.ts and src/beautify/beautify-html.d.ts, especially the linked ranges. Trace how templating formatter settings are passed into the HTML beautifier, then confirm that angular can be selected and remains disabled by default for existing users.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.