microsoft / microsoft/vscode-html-languageservice
HTML folding range should include end tag
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 284
- Forks
- 138
- Avg merge
- 19h 11m
- Merged PRs (30d)
- 5
Description
Currently, the VSCode HTML folding range doesn't include the end tag. Recently a change was made to XML Language Support by Red Hat to enclose the end tag:
This suggestion came at a request to improve readability and save screen space: https://github.com/eclipse/lemminx/issues/1178
It would be nice for the VSCode HTML language support to also include this in it's folding range.
If this is a suggestion you believe is important to add, I've already made a POC ready to pr.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the VSCode HTML language service's folding-range implementation and its existing tests, then compare the requested behavior with the linked XML Language Support change. Done means HTML folding ranges include the end tag and the relevant tests confirm the updated range.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, typescript
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100