microsoft / microsoft/vscode-github-issue-notebooks
No warning/error when opening invalid notebook file
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 237
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Type: Bug
- Create a issue notebook
- Edit the raw json of the file an add a trailing
,to make the json invalid - Open the file again in the notebook editot
bug
The notebook is empty. No errors/warnings are shown
Extension version: 0.0.130
VS Code version: Code - Insiders 1.83.0-insider (Universal) (4268e464763087044d0c1b5bdd37ebbe683cadfa, 2023-09-29T20:44:15.716Z)
OS version: Darwin arm64 23.0.0
Modes:
System Info
| Item | Value |
|---|---|
| CPUs | Apple M2 Max (12 x 24) |
| GPU Status | 2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled |
| Load (avg) | 5, 4, 3 |
| Memory (System) | 64.00GB (0.50GB free) |
| Process Argv | --crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda |
| Screen Reader | no |
| VM | 0% |
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the VS Code notebook editor using a notebook whose raw JSON has a trailing comma. Trace the notebook opening path to determine where invalid JSON is handled; done means opening the file shows a warning or error instead of silently displaying an empty notebook.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100