microsoft / microsoft/vscode-generator-code

Inline the syntax highlighting schema?

Open
#517 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.6k
Forks
262
Avg merge
15d 22h
Merged PRs (30d)
1

Description

The generator template links to a json schema outside the project (by the github user martinring, here) -- if the schema is a good thing to include, could it perhaps be inlined into this repository? Otherwise if that file is removed or changed, it has an impact on downstream users; and also the legitimacy of the schema is easier to assess when that link is found in a syntax highlighter.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with generators/app/templates/ext-language/syntaxes/new.tmLanguage.json and compare its external schema link with the referenced martinring/tmlanguage.json. Determine whether the schema should be included in this repository, then verify that generated syntax-highlighter files use the intended schema reference and that downstream users are no longer exposed to an unnecessary external dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.