microsoft / microsoft/vscode-extension-samples
Deprecated rootUri is used for lsp-multi-server-sample
@dbaeumer is already working on this.
Since Jul 14, 2021.
- Dominant language
- TypeScript
- Stars
- 10.2k
- Forks
- 3.9k
- PR merge metrics
- No merged PRs in 30d
Description
The example server is still using params.rootUri https://github.com/microsoft/vscode-extension-samples/blob/master/lsp-multi-server-sample/server/src/server.ts#L25
Which makes sense in the usecase, but as it says, that it's deprecated and we should use params.workspaceFolders which does not help us to figure out which workspace folder this server was started for.
So is starting a server for every workspace folder still what's recommended? https://github.com/microsoft/vscode-extension-samples/blob/master/lsp-multi-server-sample/README.md#L5
Or should we handle this different nowadays?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.