microsoft / microsoft/vscode-edge-devtools

Consider changing your activation events

Open
#820 1 comment 0 reactions 2 assignees View on GitHub

@antross is already working on this.

Since Jan 18, 2022.

enhancement tracked
Dominant language
TypeScript
Stars
827
Forks
358
Avg merge
20h 32m
Merged PRs (30d)
10

Description

Hi from the VS Code core team 👋

I noticed you have a lot of very eager activation events:

https://github.com/microsoft/vscode-edge-devtools/blob/7bc1699ca9a98bcda09ba954df2658fa543a0909/package.json#L39-L57

Ideally extensions would only activate when they are actually being used (ie. to debug Edge). Here are some thoughts:

  • Use onDebugInitialConfigurations and onDebugResolve instead of onDebug (docs recommends this). I rarely debug using this extension but often debug, so the Edge extension ends up activating and wasting system resources.
  • Avoid onLanguage unless you have a compelling reason to do so, opening a typescript file does not imply I want to debug it via Edge.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.