microsoft / microsoft/vscode-edge-devtools

Running the command vscode-edge-devtools-view.close-instance does not close the instance

Open
#1,188 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug tracked
Dominant language
TypeScript
Stars
827
Forks
358
Avg merge
20h 32m
Merged PRs (30d)
10

Description

Environment (please complete the following information):

  • OS: Microsoft Windows 10 Pro v2009 (Win32NT 10.0.19044.0)
  • Machine: Surface Pro 3
  • Extension version: 2.1.1

Describe the bug:

When launching a debugging session with default settings (e.g. no launch.json) using the Launch Edge Headless and attach DevTools (workspace) or any other preset, the command vscode-edge-devtools-view.close-instance in Ctrl + Shift + P, does not close the instance. You can close it normally using either the Edge DevTools sidebar or the floating debug menu.

Unless I've misunderstood something, I'd think vscode-edge-devtools-view.close-instance should do the same as the close instance buttons. If this is not intended behavior, I think this would be a nice feature request for use with Visual Studio Code Tasks and Launch configurations. Though issue #846 needs to be fixed for that to be useful.

Repro steps:

  1. Start a debugging session using a default preset like Launch Edge Headless and attach DevTools (workspace)
  2. Open the command launcher with Ctrl + Shift + P
  3. Run the command vscode-edge-devtools-view.close-instance or Microsoft Edge Tools: Close Instance

Expected behavior:

  1. Start a debugging session using a default preset like Launch Edge Headless and attach DevTools (workspace)
  2. Open the command launcher with Ctrl + Shift + P
  3. Run the command vscode-edge-devtools-view.close-instance or Microsoft Edge Tools: Close Instance
  4. The session ends and the Edge DevTools closes like when you end the session through the Edge DevTools sidebar or floating menu.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the vscode-edge-devtools-view.close-instance command used from the Command Palette, then compare it with the close-instance buttons in the Edge DevTools sidebar and floating debug menu. Reproduce the default-preset debugging session and verify that the command ends the session and closes Edge DevTools in the same way.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.