microsoft / microsoft/vscode-deviceid

Update code based on fs-extra for async - Related to #16

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Update code based on comment: Since we're already using fs-extra, can you use https://github.com/jprichardson/node-fs-extra/blob/master/docs/pathExists.md instead? Related to #16

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the comment referenced by issue #16, then locate the existing filesystem existence check in the TypeScript code. Compare its use with fs-extra's pathExists documentation; done means the relevant check uses that API and the existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.