microsoft / microsoft/vscode-debugadapter-node

Custom events are missing their session property in the test DebugClient

Open
#210 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
306
Forks
90
Avg merge
8h 36m
Merged PRs (30d)
3

Description

Currently in the test debug client, if you listen for a custom event like this:

this.on("dart.serviceExtensionAdded", (e: DebugSessionCustomEvent) => console.log(e.session));

session doesn't seem to be defined. I did have a look, but I'm not really sure how to fix this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the test debug client and the code that dispatches custom events such as dart.serviceExtensionAdded. Trace how DebugSessionCustomEvent is created and check where its session property should be supplied. Done means the listener example receives a defined session value.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.