microsoft / microsoft/vscode-debugadapter-node

Allow Logger consumers to customize log output

Open
#201 0 comments 0 reactions 1 assignee View on GitHub

@roblourens is already working on this.

Since Sep 19, 2018.

feature-request
Dominant language
TypeScript
Stars
306
Forks
90
Avg merge
8h 36m
Merged PRs (30d)
3

Description

https://github.com/Microsoft/vscode-chrome-debug-core/pull/355 tries to clean script contents from logged messages, and it's a very awkward hack via patching a method on Logger. We should provide a nice way for consumers to customize the output.

We can add protected methods to the LoggingDebugSession that format log messages, so they can be overridden.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.