microsoft / microsoft/vscode-debugadapter-node
Make DebugClient easier to extend (eg. by making private things protected)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 306
- Forks
- 90
- Avg merge
- 8h 36m
- Merged PRs (30d)
- 3
Description
The DebugClient class is excellent for testing DAs, but there are some things missing that are more effort to add than they could be.
For example, the hitBreakpoint method works great for launch requests but can't be used for attach requests (since it does the launch itself). Making our own copy of hitBreakpoint means also copying a lot of the private methods resulting in a lot of duplication.
It'd be great if everything was made protected so we could extend it.
(For the specific example above, maybe hitBreakpoint could also check the launch args and attach if it's an attach request?)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TypeScript DebugClient class and reviewing its private methods, especially hitBreakpoint and the launch/attach request handling. Determine which extension points are needed without duplicating private methods; done should support extending the client for attach requests as well as launch requests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools, testing-qa
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100