microsoft / microsoft/vscode-custom-data
Regression of white-space values: getValuesFromSyntax no longer handles white-space's syntax
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 240
- Forks
- 95
- PR merge metrics
- No merged PRs in 30d
Description
Regression of #55.
https://github.com/microsoft/vscode-custom-data/pull/56/files#diff-f0bbe48b1fb24ff03380a7b65cd9212a4e93584c37867b3201809db34b1fb40bR122 no longer works because the syntax for white-space is now normal | pre | nowrap | pre-wrap | pre-line | break-spaces | [ <'white-space-collapse'> || <'text-wrap'> || <'white-space-trim'> ] (|| causes it to not match I think).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading getValuesFromSyntax and the referenced changes in pull request #56, then compare its handling with the current white-space syntax in the issue. The work is done when the syntax containing || is recognized correctly without regressing the existing white-space values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100