microsoft / microsoft/vscode-custom-data

Missing "r" property from attribute list

Open
#46 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
240
Forks
95
PR merge metrics
No merged PRs in 30d

Description

The following code should be valid as per spec from SVG2.0:
https://www.w3.org/TR/SVG/geometry.html#RProperty

.vertex {
        filter: drop-shadow(rgba(207, 171, 255, 0.9) 0px 0px 20px);
        fill: #b082ee;
        r: 20;
        stroke: 5;
    }

Unknown property: 'r' lit-plugin(no-invalid-css)

I'm happy to do a PR, but unclear what's the process and pipeline to add it correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository's custom data documentation and sample to find how CSS properties are represented and validated. Confirm the SVG2 specification for the r property, then determine the relevant validation path and verify that the reported Unknown property message no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.