microsoft / microsoft/vscode-cpptools
clang-tidy modernize-use-default-member-init fix generates invalid code (extra `,`)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
See https://github.com/llvm/llvm-project/issues/54603 . Repro is with the pending 1.10.1 vsix.
We could theoretically workaround the bug by checking for clang-tidy versions with the bug and then modify/fix the edit used. Disabling the fix is another option, but it still seems useful (after manually removing the extra ,).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked LLVM issue and reproducing the clang-tidy modernize-use-default-member-init fix with the pending 1.10.1 VSIX. Then trace how the extension handles the generated edit. Done means the repro no longer produces invalid code, or the affected fix is explicitly handled; verify against the same reproduction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100