Formatting with a symlinked folder may randomly corrupt files

Open
#5,061 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp, typescript
Domain
tooling

Research direction

Start by reviewing the linked 0.27.0-insiders release note and the original issue comment, then reproduce formatting from a symlinked working directory in a multi-root workspace. Done means repeated formatting no longer corrupts files, or the issue is confirmed fixed by the newer multi-root implementation.

Written by the indexing model from the issue text.

Description

bug Feature: Code Formatting investigate: repro Language Service symlinks

Our latest Insiders release has a new multi-root implementation (which fixes this bug): https://github.com/microsoft/vscode-cpptools/releases/tag/0.27.0-insiders. Please let us know if you find any multi-root-related bugs or regressions so we can prioritize fixing those for 0.27.0.

I am affected by the bug. My working directory is a symlink, and once in a while when I reformat the code my file becomes corrupted. I am using /0.27.0-insiders2

Originally posted by @olzhas in https://github.com/microsoft/vscode-cpptools/issues/1073#issuecomment-595361067

Dominant language
TypeScript
Stars
6.2k
Forks
1.7k
Avg merge
14h 46m
Merged PRs (30d)
61

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/vscode-cpptools

All issues in microsoft/vscode-cpptools

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.