microsoft / microsoft/vscode-cpptools

AmigaOS4 support

Open
#5,057 9 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request Language Service parser
Dominant language
TypeScript
Stars
6.2k
Forks
1.7k
Avg merge
14h 46m
Merged PRs (30d)
61

Description

Hi,

I use macOS to cross compile for Amiga OS 4 and use VS Code as text editor.

Screen Shot 2020-03-04 at 23 16 49

As you can see in the screenshot it complaints about to few arguments, but actually this is a feature of the ppc-amigaos-gcc as the first argument is implicit.
Eg an API is declared like this

struct PCIDevice
{
    BOOL APICALL (*Lock)(struct PCIDevice *Self, UBYTE Mode);
    void APICALL (*Unlock)(struct PCIDevice *Self);
}

but called like this
my_device->Lock(PCI_LOCK_EXCLUSIVE);

Without the Self argument. The magic is in the APICALLqualifier that makes the compiler take care of this.

My question is, can I some how make the parser understand this and stop complaining about too few arguments?

Cheers
Steen

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the too-few-arguments diagnostic in VS Code with the ppc-amigaos-gcc example using the APICALL qualifier. Trace the C/C++ parser's handling of function-pointer calls and calling qualifiers, then verify that the implicit Self argument no longer produces a diagnostic while ordinary calls still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, vscode
Domain
compilers, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.