microsoft / microsoft/vscode-cpptools
Find All References doesn't find references in preprocessor statements (also affects Rename Symbols)
Open
Nobody has claimed this yet.
bug
Feature: Find All References
Language Service
Works in VS
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
#define DEF1 1
#define DEF2 DEF1
#ifdef DEF1
int main(){
return DEF1;
}
#endif
Bug: Find All References only finds the "return DEF1;" and not the cases in the #define/#ifdef. VS handles that case correctly.
It also affects rename (which uses find all references).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied C preprocessor example and trace the Find All References path used by Rename Symbols. Done means references in both #define and #ifdef statements are found, and renaming covers those occurrences as well as the return statement.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100