microsoft / microsoft/vscode-cpptools

format code issue: break in macro,

Open
#13,761 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

external Feature: Code Formatting Language Service
Dominant language
TypeScript
Stars
6.2k
Forks
1.7k
Avg merge
14h 46m
Merged PRs (30d)
61

Description

AlignArrayOfStructures: Left

ORIGIN:

const struct reg aa[] __CMN_RODATA = {
    { abc,    0, format, code },
    { abcd2,  0, format, code },
    { aaaa,   0, why,    why  },
    { whyyyy, 0, why,    why  },
};

add macro:


const struct reg aa[] __CMN_RODATA = {
#if A
    { abc,   0, format, code },
    { abcd2, 0, format, code },
#else
    { aaaa, 0, why, why },
    { whyyyy, 0, why, why },
#endif
};

if 0:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the formatting behavior from the C snippets using AlignArrayOfStructures: Left, including the version with #if/#else and the if 0 case. The issue names no source files or tests, and the expected formatted output is only shown in unavailable images; done should mean agreeing on the intended formatting and adding a regression test for the macro cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.