microsoft / microsoft/vscode-cpptools
Switch back to using the official `editorconfig` module
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
We had previously been using the editorconfig module to parse .editorConfig files. Due to an issue that occurred on some systems, because of a dependency of that module, we removed it in favor of replicating the code we needed:
https://github.com/microsoft/vscode-cpptools/issues/12529
https://github.com/microsoft/vscode-cpptools/pull/12579
I also opened a bug against editorconfig core: https://github.com/editorconfig/editorconfig-core-js/issues/128
It looks like that bug is now fixed, so we may be able to switch back to using the editorconfig module.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the extension for the replicated .editorconfig parser and the current dependency declarations, then review the linked editorconfig-core-js issue and prior pull request for the original failure and its fix. Done means the official editorconfig module is used again without reproducing the reported system-specific dependency problem, with the existing parsing behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100