Public members of private base class show in autocomplete list

Open
#13,215 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp, typescript, vscode
Domain
devtools

Research direction

Reproduce the issue in a standalone .cpp file using the A and B classes shown, then trace the autocomplete member-filtering entry point in the C/C++ extension. The fix is done when public members inherited through a private base class are omitted outside the derived class, while accessible members remain available.

Written by the indexing model from the issue text.

Description

bug Feature: Auto-complete Language Service Works in VS
Environment
  • OS and Version: Windows 10 Pro, 22H2, 19045.5371
  • VS Code Version: 1.96.4 (user setup)
  • C/C++ Extension Version: 1.23.5
  • If using SSH remote, specify OS of remote machine: No SSH
Bug Summary and Steps to Reproduce

Bug Summary:
When the autocomplete list for members of a class shows while typing, public members (fields, methods, enums, etc.) from private base classes will show in the list as if the the base class was public, despite them being inaccessible outside of the derived class.

Steps to reproduce:

  1. Create a standalone .cpp file without any extension or workplace-specific settings.
  2. Create a class that privately inherits from a base class.
  3. In a function (not a method of the derived class) with a local variable of this derived class, open the autocomplete list by typing . after the name.
  4. Public members of base class will show in the list, even though it is private.
class A {
public:
    int value;
};

class B : private A {};

void foo() {
    B b;
    // Typing here: `value` member is visible in list that pops up.
    b.
}

Image

Expected behavior:
Public members of a private base class should not appear in the autocomplete list in a scope where they can't be used, just like how is done with normal private/protected members.

Configuration and Logs
"C_Cpp.autoAddFileAssociations": false,
Other Extensions

Issue persists after disabling all other extensions and reloading window.

Additional context

No response

Dominant language
TypeScript
Stars
6.2k
Forks
1.7k
Avg merge
14h 46m
Merged PRs (30d)
61

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/vscode-cpptools

All issues in microsoft/vscode-cpptools

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.