microsoft / microsoft/vscode-cpptools

Outline entries incorrect for specialized template classes containing namespace scopes

Open
#12,908 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Feature: Document Symbol Language Service
Dominant language
TypeScript
Stars
6.2k
Forks
1.7k
Avg merge
14h 46m
Merged PRs (30d)
61

Description

Repro code:

namespace test_namespace
{
	class A
	{
	};
}

template <typename T2>
class B
{
};

template <>
class B<test_namespace::A>
{
};

Resulting outline:

Image

It looks like a :'s from the namespace scope operator is being misinterpreted as a base-specifier colon.

(Maybe a possible fix would involve use of the lexer/BraceMatcher.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied C++ reproduction and inspect the outline parsing around the lexer or BraceMatcher, as suggested in the issue. Done means the specialized template class is represented correctly in the outline, with the namespace scope operator distinguished from a base-specifier colon.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.