microsoft / microsoft/vscode-cpptools
Extract to function sometimes adds a #include with the folder missing from the path
Open
@sean-mcmanus is already working on this.
Since Oct 29, 2024.
bug
Feature: Extract to function
Language Service
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
We have a repro internally with main.cpp line 208 (call to fclose). It adds "<file>.h" instead of "<parentFolder>/<file>.h" where <parentFolder> is not in the includePaths (but its parent is).
It's possible the bug could repro with Create Declaration/Definition too. I'm not sure yet if it ever adds the <parentFolder>.
I'm not sure if it repros with VS yet.
With Debug bits it fails with "Unknown error" before any code is generated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.