microsoft / microsoft/vscode-cpptools
Migrate from proposed API `terminalDataWriteEvent` to new `terminalShellIntegration`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
My understanding is that the terminalDataWriteEvent proposed API we're using will never be published to stable and has been superseded by another feature.
The code for terminalDataWriteEvent refers to:
// https://github.com/microsoft/vscode/issues/78502
//
// This API is still proposed but we don't intent on promoting it to stable due to problems
// around performance. See #145234 for a more likely API to get stabilized.
#145234 has since been closed as completed, moving terminalShellIntegration out of proposed and into stable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the extension for references to the proposed terminalDataWriteEvent API and inspect the surrounding terminal integration code. Replace its usage with the stable terminalShellIntegration API, then verify that terminal integration behavior remains correct; the issue does not name a specific file or test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100