microsoft / microsoft/vscode-cpptools

'Extract to member function' doesn't create a static member function when used in static member function not defined in the class declaration

Open
#11,767 0 comments 0 reactions 1 assignee View on GitHub

@sean-mcmanus is already working on this.

Since Dec 8, 2023.

Feature: Extract to function Language Service Visual Studio
Dominant language
TypeScript
Stars
6.2k
Forks
1.7k
Avg merge
14h 46m
Merged PRs (30d)
61

Description

Repro is

class foo
{
	static int func();
};


int foo::func()
{
    return 0; // Use Extract to member function on this line
}

The bug repros in VS too. The bug doesn't repro if the static function is defined inline in the class declaration.

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.