microsoft / microsoft/vscode-cpptools
Extract to function is available if a declaration isn't selected and generates invalid code
Open
@sean-mcmanus is already working on this.
Since Sep 22, 2023.
bug
Feature: Extract to function
insiders
Language Service
Visual Studio
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
Use Extract to function on the code below with the selection shown in the screenshot (which excludes part of the variable declaration):
int main()
{
int i = 0;
return i;
}
Bug: It generates invalid code int return NewFunction(i);. Ideally, it would show the "Expand selection" command, or otherwise don't show the Extract to function code action (and show an error explanation if it's invoked by the keyboard). It also repros with VS.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.