microsoft / microsoft/vscode-cpptools
The newline is missing before the function definition with Create Declaration / Definition if the existing source file is missing the `#include`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 6.2k
- Forks
- 1.7k
- Avg merge
- 14h 46m
- Merged PRs (30d)
- 61
Description
Use Create Declaration / Definition on a function declaration in a header file that has a corresponding source file that doesn't include the header but has some other function definition in it.
Bug: The definition gets created in the source file with without a newline separating the previous definition.
The root cause might be shared with https://github.com/microsoft/vscode-cpptools/issues/10164
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Create Declaration / Definition command path for a function declaration in a header, then compare the source-file insertion behavior described here with issue #10164. Done means the generated definition is separated from an existing function definition by a newline when the source file does not include the header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, typescript, vscode
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100