microsoft / microsoft/vscode-containers
Why move node_modules to parent directory?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 139
- Forks
- 87
- Avg merge
- 9h 15m
- Merged PRs (30d)
- 9
Description
https://github.com/microsoft/vscode-docker/blob/018c92815ff2eeed50ec9e9af1d842ebf7a7a329/resources/templates/node/Dockerfile.template#L5
This line intrigues me.
Why the mv node_modules ../ part? Why move node_modules up a directory?
Should this be in a generic Node.js Dockerfile template?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect resources/templates/node/Dockerfile.template at line 5 and the surrounding Node container template usage. Trace why node_modules is moved to the parent directory and determine whether that behavior is specific to this template or belongs in a generic Node.js Dockerfile template. Done means the rationale and template scope are documented or the requested template change is clearly specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, dockerfile, node.js
- Domain
- devops, tooling
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100