microsoft / microsoft/vscode-cmake-tools

Compiler "notes" aren't turned into Problems

Open
#2,527 0 comments 1 reaction 0 assignees View on GitHub
enhancement Feature: diagnostics
Dominant language
TypeScript
Stars
1.7k
Forks
546
Avg merge
2d 16h
Merged PRs (30d)
32

Description

### Brief Issue Summary

Do "CMake: Build" with code that passes something like a `std::vector` to a parameter that takes a `std::vector&&` (i.e. `std::move` is missing). The result has multiple "notes" with cl.exe. The notes should be populated in the Problems. My repro was with the cl.exe compiler.

Otherwise, it just shows 1 problem in ``, which isn't helpful and the command line needs to be looked at.

You can run the "C/C++: Run Code Analysis On Active File" to compare the clang-tidy problems processing, which correctly handles the "notes" output (although that shows the clang results instead of cl.exe").

### CMake Tools Diagnostics

```shell
Unneeded.
```

### Debug Log

```shell
Unneeded.
```

### Additional Information

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the diagnostic processing used by "CMake: Build" and compare it with the "C/C++: Run Code Analysis On Active File" handling of clang-tidy notes. Reproduce the cl.exe std::vector and std::vector&& case, then verify that related compiler notes appear in Problems instead of only the xutility error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, typescript
Domain
build-system, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.