microsoft / microsoft/vscode-azurestaticwebapps

Remove unneeded `BROWSER: 'none'` environment variable

Open
#711 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
99
Forks
39
Avg merge
3d 7h
Merged PRs (30d)
2

Description

https://github.com/microsoft/vscode-azurestaticwebapps/blob/1d22971011fd881ad7146983c0030f1b6eb2ae92/src/cli/SwaCliTaskProvider.ts#L107-L113

As of v1.0.0, this is now handled inside the SWA CLI here.

added in PR: https://github.com/Azure/static-web-apps-cli/pull/472

Probably a good idea to wait until after we release #710 to give users time to update to v1.0.0

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect src/cli/SwaCliTaskProvider.ts at lines 107-113 and compare the SWA CLI v1.0.0 handling linked in the issue. Confirm release #710 has shipped so users can update, then remove the obsolete BROWSER environment variable and verify the extension no longer sets it.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, typescript, vscode
Domain
cli, tooling
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.