microsoft / microsoft/vscode-azurecontainerapps
Check value of string before running asyncValidationTask
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 42
- Forks
- 21
- Avg merge
- 3d 7h
- Merged PRs (30d)
- 2
Description
I noticed this with RegistryNameStep but if you hit 'enter' right away before you have typed anything, it will try to run validateNameAvailability with an empty string. This causes the name validation step to hang. You can pretty easily get out of it by hitting esc, but I don't think a user would know why it just suddenly froze. Not a huge concern, but perhaps we should automatically run validateInput in asyncValidationTask as well, just to make sure that validateInput happens at least once.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with RegistryNameStep and read asyncValidationTask alongside validateInput. Reproduce the empty Enter submission, then ensure validation runs before validateNameAvailability so the name-validation step does not hang; confirm the existing escape behavior is no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, typescript, vscode
- Domain
- cloud, developer-experience
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100