microsoft / microsoft/vscode-atom-keybindings
Join Lines (cmd+j) should use a `"when"` clause.
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 150
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
Extracted from https://github.com/microsoft/vscode/issues/97906
The "when" clause should be "editorTextFocus && !editorReadonly".
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in package.json at the keybinding entry around lines 520-526 referenced by the issue. Check the Join Lines (cmd+j) command and update its "when" clause to the requested editorTextFocus and non-readonly condition; it is done when that entry contains the specified clause.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100