microsoft / microsoft/vscode-atom-keybindings
Should be used oem_comma instead of comma glyph?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 150
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
For international or non-US keyboards is preferred to use oem_comma instead of ,.
Tested only on windows and linux,
Old:
{
"mac": "cmd+,",
"win": "ctrl+,",
"linux": "ctrl+,",
"key": "ctrl+,",
"command": "workbench.action.openGlobalSettings"
},
New:
{
"mac": "cmd+oem_comma",
"win": "ctrl+oem_comma",
"linux": "ctrl+oem_comma",
"key": "ctrl+oem_comma",
"command": "workbench.action.openGlobalSettings"
},
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the keybinding definition containing the workbench.action.openGlobalSettings command and compare it with the old and new examples in the issue. Replace the comma glyph with oem_comma for the affected platform entries, then verify that the keybinding remains valid for Windows and Linux and matches the requested wording.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100