microsoft / microsoft/vs-threading

VSTHRD200 calculates all awaitable types, but only caches one

Open
#829 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

analyzers enhancement
Dominant language
C#
Stars
1k
Forks
160
Avg merge
1d 12h
Merged PRs (30d)
28

Description

This block calculates all awaitable types, but only caches the one requested by an argument. This results in a large amount of recalculation.

https://github.com/microsoft/vs-threading/blob/bcec58047f3328d00a7747e69a1e0e5dd791564d/src/Microsoft.VisualStudio.Threading.Analyzers/DiagnosticAnalyzerState.cs#L42-L49

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/Microsoft.VisualStudio.Threading.Analyzers/DiagnosticAnalyzerState.cs#L42-L49, linked from the issue. Trace how the block calculates awaitable types and how the argument selects the cached value; done means the calculated awaitable types are cached rather than recalculated for each request.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.