microsoft / microsoft/vs-threading
Incorrect state machine names in VB code
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1k
- Forks
- 160
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 28
Description
Bug description
!dumpasync doesn't work for code compiled with Visual Basic.
Repro steps
Use !dumpasync when code is compiled with Visual Basic.
Expected behavior
It should not be obvious that the async state machines are coming from Visual Basic code.
Actual behavior
Additional context
It appears that the following changes are needed for VB code:
-
<>1__state→$State -
<>t__builder→$Builder -
<>4__this→$VB$Me(this one I'm not quite sure of)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/SosThreadingTools/DumpAsyncCommand.cs at the referenced lines around 43, 47, and 208. Review how !dumpasync identifies async state-machine fields, then verify it handles the Visual Basic names $State, $Builder, and $VB$Me when run against Visual Basic-compiled code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, visualbasic
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100