microsoft / microsoft/vs-threading
AsyncReaderWriterLock.Completion doesn't seem to be implemented correctly
Open
Nobody has claimed this yet.
bug
- Dominant language
- C#
- Stars
- 1k
- Forks
- 160
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 28
Description
Not sure anyone uses that. But it appears that this CompletionSource is not implemented correctly. It is not being set when any read lock is released, or any request is cancelled after Complete() is called.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate AsyncReaderWriterLock.Completion and trace its CompletionSource through read-lock release and request cancellation after Complete() is called. Confirm the expected completion behavior and add or update focused tests for both cases; done means the CompletionSource is set when either event leaves no remaining work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100