microsoft / microsoft/vs-threading

Provide a non-net472 alternative to ThrowIfNotOnUIThread to satisfy VSTHRD010

Open
#1,025 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

analyzers enhancement
Dominant language
C#
Stars
1k
Forks
160
Avg merge
1d 12h
Merged PRs (30d)
28

Description

Is your feature request related to a problem? Please describe.

VSTHRD010 asks to use ThreadHelper.ThrowIfNotOnUIThread() for sync methods.
ThreadHelper is only available for the net472 target. Microsoft.VisualStudio.Threading is available for other targets as well.

Describe the solution you'd like

Microsoft.VisualStudio.Threading should provide a ThrowIfNotOnUIThread() method for all platforms for which VSTHRD010 is generated.
The VSTHRD010 error message should be updated to instruct using the ThrowIfNotOnUIThread() provided by Microsoft.VisualStudio.Threading.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the VSTHRD010 analyzer and its current references to ThreadHelper.ThrowIfNotOnUIThread(), then inspect the Microsoft.VisualStudio.Threading target frameworks. Done means a non-net472 ThrowIfNotOnUIThread() is available on every target where VSTHRD010 is generated and the diagnostic message points to it.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.