microsoft / microsoft/vs-streamjsonrpc

Add mechanism to access JsonRpcRequest instance from service implementation

Open
#1,337 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
937
Forks
178
Avg merge
3d 1h
Merged PRs (30d)
28

Description

It would be useful to be able to access the JsonRpcRequest (or in my particular case the RequestId) from service implementations so that I can do out-of-band association between client and server requests. Specifically, I'm trying to post-facto recreate a session after it's been terminated with information stored on both parties. To avoid async and threading related race conditions I think it would need to be provided as a special argument to the handler function, but I don't know what the performance implications of adding this would be or the implementation approach.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how service implementations are invoked and how JsonRpcRequest data reaches the handler function. Investigate whether a special handler argument can expose the request or RequestId without introducing async or threading races, and assess the performance implications. Done requires an agreed API and implementation approach, but the issue does not identify files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design, distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.