microsoft / microsoft/vidur

Potential Issue Regarding Profiling

Open
#72 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
682
Forks
128
Avg merge
9h 44m
Merged PRs (30d)
1

Description

Dear maintainers,

Recently I attempted using the profiling workflow in the vidur project and collect profiling data on AWS EC2 instances. I experimented with the P5 48X which has 8X H100 connected using DGX with 8 GPUs for CodeLlama-34b-Instruct-hf. The code I used are vidur main branch and sarathi-serve vidur branch. However, the profiling results I got differ significantly from the ones in the provided data folder.

I have attached my collected data. I noticed several differences and potential issues.

  1. New profiled data uses flashinfer, while the reference uses flash_attention.
  2. New profiling data has additional columns for kv_cache_save.

Using the profiling data, vidur's prediction varies significantly from using the reference data. Could you please help me understand the correct profiling workflow?

New_H100_codellama_CodeLlama-34b-Instruct-hf_attention.csv

Thank you for your help.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Vidur's profiling workflow and compare the attached New_H100_codellama_CodeLlama-34b-Instruct-hf_attention.csv with the reference data in the provided data folder. Check the reported flashinfer versus flash_attention entries and the additional kv_cache_save columns, then document the correct workflow and the source of the prediction differences.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, python
Domain
machine-learning, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.