Regarding the judgment condition for TFFTViolationLowMemoryCase
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 682
- Forks
- 128
- Avg merge
- 9h 44m
- Merged PRs (30d)
- 1
Description
I am studying how Vidur determines bottlenecks, and I noticed that both TFFTViolationLowMaxBatchSizeCase and TFFTViolationLowMemoryCase involve checking batch_size_obs. It seems that batch_size_obs should be a specific batch size value, but in TFFTViolationLowMemoryCase, it is directly compared with LOW_MEMORY_BATCH_SIZE_THRESHOLD. Could this be a mistake?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for TFFTViolationLowMaxBatchSizeCase, TFFTViolationLowMemoryCase, batch_size_obs, and LOW_MEMORY_BATCH_SIZE_THRESHOLD, then read how the two judgment conditions are used. Confirm the intended batch-size semantics and add or update coverage for the low-memory condition so the behavior is unambiguous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100