microsoft / microsoft/vcpkg

[sdl2pp] Portfile installs cmake files into wrong directory

Open Beginner friendly
#52,191 0 comments 0 reactions 0 assignees View on GitHub
category:port-feature
Dominant language
CMake
Stars
27.5k
Forks
7.7k
Avg merge
2d 19h
Merged PRs (30d)
321

Description

### Is your feature request related to a problem? Please describe.

The existing port for sdl2pp has this:

```
vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake")
```

But it should be

```
# Upstream installs config to lib/cmake/SDL2pp/ — fix-up must target that
# exact directory so files land at share/sdl2pp/ (not share/sdl2pp/SDL2pp/).
vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake/SDL2pp")
```

As currently written, the port prevents use of the `SDL2pp::SDL2pp` cmake target because cmake cant find the cmake target files for SDL2pp (they are in the wrong directory).

### Proposed solution

See above for proposed fix.

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Locate the sdl2pp portfile and inspect its vcpkg_cmake_config_fixup entry. Verify the upstream SDL2pp config directory and confirm that the SDL2pp::SDL2pp target files are installed under share/sdl2pp/ so CMake can find them.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.