microsoft / microsoft/vcpkg

[utf8proc] CMake package version support

Open
#39,176 2 comments 0 reactions 1 assignee View on GitHub

@MonicaLiu0311 is already working on this.

Since Jun 7, 2024.

category:port-feature depends:upstream-changes
Dominant language
CMake
Stars
27.5k
Forks
7.7k
Avg merge
2d 19h
Merged PRs (30d)
321

Description

### Is your feature request related to a problem? Please describe.

The utf8proc port adds support for CMake package by https://github.com/microsoft/vcpkg/blob/master/ports/utf8proc/export-cmake-targets.patch . So we can use `find_package(unofficial-utf8proc)` (or `find_package(utf8proc NAMES unofficial-utf8proc)`).

But it doesn't provide version information. So we can't specify required version such as `find_package(unofficial-utf8proc 2.9.0)`.

### Proposed solution

Could you also provide `unofficial-utf8proc-version.cmake`?
We can create it by `write_basic_package_version_file()`.
See also: https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#command:write_basic_package_version_file

FYI: A PR that adds support for CMake package to upstream also uses it: https://github.com/JuliaStrings/utf8proc/pull/260

### Describe alternatives you've considered

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.