[openblas] 64bit build fails due to redefinition of BLASLONG <0.3.15>
Open
@Cheney-W is already working on this.
Since Nov 1, 2021.
category:port-bug
- Dominant language
- CMake
- Stars
- 27.5k
- Forks
- 7.7k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 321
Description
Library name: openblas
New version number: 0.3.15
Other information that may be useful (release notes, etc...)
OpenBlas fails to build on 64-bit windows, and requires a manual definition of OS_WINNT and __64BIT__.
if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "x86_64" OR "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL AMD64)
# use inside openblas_common.h
if(WIN32)
target_compile_definitions(main PRIVATE OS_WINNT=1)
endif()
target_compile_definitions(main PRIVATE __64BIT__=1)
endif()
This is because BLASLONG is defined two times.
C:\proj\build\vcpkg_installed\x64-windows\include\openblas\openblas_config.h:55
#if defined(OPENBLAS_OS_WINDOWS) && defined(OPENBLAS___64BIT__)
typedef long long BLASLONG;
typedef unsigned long long BLASULONG;
#else
typedef long BLASLONG;
typedef unsigned long BLASULONG;
#endif
C:\proj\build\vcpkg_installed\x64-windows\include\openblas_common.h:36
#if defined(OS_WINNT) && defined(__64BIT__)
typedef long long BLASLONG;
typedef unsigned long long BLASULONG;
#else
typedef long BLASLONG;
typedef unsigned long BLASULONG;
#endif
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.