microsoft / microsoft/vcpkg

[jemalloc] build failure, "versions" feature can't recognize port's current version format 4.3.1-4 in "overrides" section

Open
#17,409 9 comments 0 reactions 3 assignees View on GitHub

Nobody has claimed this yet.

category:port-feature
Dominant language
CMake
Stars
27.5k
Forks
7.7k
Avg merge
2d 19h
Merged PRs (30d)
321

Description

**Host Environment**
- OS: Mac
- Compiler: apple clang 12.0

**To Reproduce**
Steps to reproduce the behavior:
`./vcpkg install --feature-flags="manifests" --feature-flags="versions"`

**Failure logs**
```
Errors occurred while parsing .../vcpkg.json
$.overrides[3] (an override): 'version' text was not a relaxed version:
Error: String '4.3.1-4' must only contain dot-separated numeric values without leading zeroes.
See https://github.com/Microsoft/vcpkg/tree/master/docs/users/manifests.md for more information.
```

**Additional context**
with the following entry in overrides section of any vcpkg.json file
```
"overrides": [
{
"name": "jemalloc", "version": "4.3.1-4"
}
]
```

Additional build failure issues with jemalloc, after removing version constraint, same platform and cmd as above
```
CMake Error at Utilities.cmake:756 (message):
GetSystemPageSize failed compilation see
vcpkg/buildtrees/jemalloc/x64-osx-dbg/GetPageSize/getpagesize.log
Call Stack (most recent call first):
CMakeLists.txt:465 (GetSystemPageSize)
```
Content of getpagesize.log
```
Change Dir: vcpkg/buildtrees/jemalloc/x64-osx-dbg/GetPageSize/CMakeFiles/CMakeTmp
2
3 Run Build Command(s):vcpkg/downloads/tools/ninja-1.10.1-osx/ninja cmTC_a18fd && [1/2] Building C object CMakeFi
4 FAILED: CMakeFiles/cmTC_a18fd.dir/getpagesize.c.o
5 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -arch x86_64 -isysroot /Applications/Xcode.app/C
6 vcpkg/buildtrees/jemalloc/x64-osx-dbg/GetPageSize/getpagesize.c:1:10: fatal error: 'windows.h' file not found
7 #include
8 ^~~~~~~~~~~
9 1 error generated.
10 ninja: build stopped: subcommand failed.
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.