microsoft / microsoft/vasim

Reading in CSVs with glob

Open
#18 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue refactor
Dominant language
Python
Stars
12
Forks
11
Avg merge
7d 23h
Merged PRs (30d)
3

Description

We are currently reading in all of the CSVs of the performance trace data using python's glob (list(self.data_dir.glob("**/*.csv"))) with no security checks. It seems like we need to do a bit more here in terms of sanitizing inputs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the performance-trace CSV discovery expression, list(self.data_dir.glob("**/*.csv")), and inspect the surrounding input handling. Determine what path sanitization and security checks are needed, add coverage for unsafe inputs, and verify that only intended CSV files are read.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.